Skip to content
NutsNews chestnut logoNutsNews Wiki

Simple guide · Overview

Page status: HistoricalHistory group: Updates

Vercel Promotion Rollback Guard Update

Infra promotion now locates Vercel production deploy runs by source commit

Visual overview

Primary diagram

System map

Infra promotion now locates Vercel production deploy runs by source commit

Render the repository-owned system map when you need it.

Diagram is not rendered yet.

View as text
Vercel Promotion Rollback Guard Update

Infra promotion now locates Vercel production deploy runs by source commit

flowchart TB
  accTitle: Vercel Promotion Rollback Guard Update
  accDescr {
    Infra promotion now locates Vercel production deploy runs by source commit
  }
  A["Vercel Promotion Rollback Guard Update"] --> B["updates/README_VERCEL_PROMOTION_ROLLBACK_GUARD_UPDATE.md"]
  B --> C["Auto-generated placeholder diagram"]

Vercel Promotion Rollback Guard Update

Fullscreen diagram view.

Vercel Promotion Rollback Guard Update

Section titled “Vercel Promotion Rollback Guard Update”

Short Summary

Section titled “Short Summary”

Infra promotion now locates Vercel production deploy runs by source commit instead of a brittle run title, and rollback cannot start without rechecking a located failed Vercel run.

What Changed

Section titled “What Changed”

The infra promotion workflow was hardened after promotion run 29832194739 dispatched Vercel production run 29832933332 for app commit d1ec4f790f2e8e4691fc57337b86188148674ef0.

The app Vercel workflow completed successfully, but the infra wait step was still looking for an older display title shape. That made the parent promotion classify the Vercel deploy as missing and incorrectly dispatch rollback run 29833155638. Rollback PR #322 merged a manifest restore to older app commit b0c602bfcadb4d563aade92b77cf79cd8c666edb; the protected rollback apply run 29833305972 was canceled before the canceled Ansible baseline reached image verification or production smoke checks.

The follow-up infra fix:

  • restores the reviewed production manifest to app commit d1ec4f790f2e8e4691fc57337b86188148674ef0;
  • finds the Vercel production workflow by workflow file, repository dispatch event, branch, dispatch timestamp, and either the current Dispatch-only Vercel production <source_commit> run-name or the legacy Deploy Vercel production <source_commit> run-name;
  • avoids using repository-dispatch headSha as the release identity because GitHub can report that field as the app repository’s current default-branch commit rather than the dispatched release commit;
  • allows automated VPS rollback only when a Vercel run id exists;
  • rechecks the located Vercel run before rollback and refuses rollback if the run-name does not match the release commit, the event is not repository_dispatch, the run is still running, the run succeeded, or the conclusion changed;
  • fails promotion when the Vercel run is missing and no protected rollback completed.

Live follow-up evidence: promotion rerun 29834135526 dispatched Vercel run 29834733790. That Vercel run’s display title was Dispatch-only Vercel production d1ec4f790f2e8e4691fc57337b86188148674ef0, but GitHub reported headSha as app commit 4d2055ea083d523454dad96393dcc935f503ccf6, the current app default-branch commit at dispatch time. The Vercel workflow still checked out and deployed the payload source commit, so the promotion wait must key off the run-name and dispatch metadata.

Operational Impact

Section titled “Operational Impact”

Operators should treat a missing Vercel workflow run as a promotion automation failure, not proof that the released app is bad. The safe response is to inspect the dispatch/run discovery path and rerun promotion after the guard is fixed. Do not use protected rollback unless a located Vercel production run for the same source commit completed with a non-success result, or production health verification proves the deployed release is actually broken.

Verification

Section titled “Verification”

Expected infra validation:

  • python3 ansible/tests/validate_release_promotion.py
  • python3 ansible/tests/validate_production_eligibility.py
  • python3 ansible/tests/validate_gate_rehearsal.py
  • python3 ansible/tests/validate_production_rollback.py
  • actionlint .github/workflows/nutsnews-release-promotion.yml
Section titled “Related Work”
  • ramideltoro/nutsnews-infra issue #323
  • ramideltoro/nutsnews-infra promotion run 29832194739
  • ramideltoro/nutsnews Vercel production run 29832933332
  • canceled rollback run 29833155638
  • canceled protected rollback apply run 29833305972